Finish off new 'packages' concept (#1586) #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobtfish
force-pushed
the
party-robot-package-import-concept
branch
2 times, most recently
from
ba85c68 to
1b3d359
Compare
jmrunkle
suggested changes
Sep 20, 2021
Contributor
jmrunkle
left a comment
jmrunkle
left a comment
There was a problem hiding this comment.
Thanks for working on this!
bobtfish
force-pushed
the
party-robot-package-import-concept
branch
from
1b3d359 to
3d87292
Compare
junedev
reviewed
Sep 20, 2021
Member
ErikSchierboom
left a comment
ErikSchierboom
left a comment
There was a problem hiding this comment.
Great! I've left some minor comments.
bobtfish
force-pushed
the
party-robot-package-import-concept
branch
from
3d87292 to
03c0989
Compare
bobtfish
force-pushed
the
party-robot-package-import-concept
branch
from
03c0989 to
24483c0
Compare
jmrunkle
approved these changes
Sep 21, 2021
Contributor
jmrunkle
left a comment
jmrunkle
left a comment
There was a problem hiding this comment.
Small nits, otherwise LGTM
Co-authored-by: Jason Runkle <[email protected]>
Co-authored-by: Jason Runkle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1586