Skip to content

Change party-robot info to only mention fmt.Sprintf (#1597) #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2021
Merged

Change party-robot info to only mention fmt.Sprintf (#1597) #1650

merged 3 commits into from
Sep 18, 2021

Conversation

@bobtfish
Copy link
Contributor

@bobtfish bobtfish commented Sep 17, 2021

No description provided.

@junedev
Copy link
Member

junedev commented Sep 18, 2021

@ErikSchierboom I would recommend having one sentence in the introduction that explains the difference between Printf and Sprintf as this confuses many students that come from languages that don't have those functions. (You suggested to completely remove Printf in the issue description #1597 which is what was done in this PR.)
The docs describe this kind of information as what "is needed to understand the fundamentals of the concept". WDYT?

junedev
junedev requested changes Sep 18, 2021
View reviewed changes
Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said here #1650 (comment) I would strongly recommend explaining the difference between Printf and Sprintf.

@bobtfish bobtfish requested a review from junedev September 18, 2021 17:04
junedev
junedev reviewed Sep 18, 2021
View reviewed changes
junedev
junedev requested changes Sep 18, 2021
View reviewed changes
Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some typos in the new sentence you added, see suggestion.

@bobtfish
Copy link
Contributor Author

bobtfish commented Sep 18, 2021

There are some typos in the new sentence you added, see suggestion.

Thanks!

@bobtfish bobtfish requested a review from junedev September 18, 2021 18:15
@junedev junedev added the x:size/small Small amount of work label Sep 18, 2021
@junedev junedev linked an issue Sep 18, 2021 that may be closed by this pull request
party-robot: tweak introduction #1597
Closed
@junedev junedev merged commit 5eb5d4a into exercism:main Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junedev junedev junedev approved these changes

Assignees

No one assigned

Labels

x:size/small Small amount of work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

party-robot: tweak introduction

2 participants

@bobtfish @junedev