Skip to content

New concept exercise city-office (docs and typespecs) #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 27, 2021
Merged

New concept exercise city-office (docs and typespecs) #693

merged 19 commits into from
Mar 27, 2021

Conversation

@angelikatyborska
Copy link
Member

WIP!

neenjaw
neenjaw reviewed Mar 20, 2021
View reviewed changes
Copy link
Contributor

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 So good, great investigation to discover this method for testing. Love the exercise, I think it will be awesome.

Where were you thinking about having it in the track? early after we introduce major value types? Then we could go back an add in @specs to other exercises.

@angelikatyborska
Copy link
Member Author

Where were you thinking about having it in the track? early after we introduce major value types?

The decision to include a struct in this exercise unfortunately forces rather late in the tree, after structs. That's not great, I might want to remove the Address struct and replace it with something else that deserves its own custom type, maybe map? Maps are much earlier in the concept tree.

Then we could go back an add in @specs to other exercises.

I don't have a strong opinion for or against this, but if some exercises got specs, then they would have to require the typespecs concept. If we don't do that, then the concept remains entirely optional 🤔

@neenjaw
Copy link
Contributor

neenjaw commented Mar 22, 2021

If you rebase on main, it will then drop the 1.6 ci check. 😄

@angelikatyborska
Copy link
Member Author

I'll sneak in some more reputation points in this PR 🐍 I think every PR that adds a whole exercise should a major one.

@angelikatyborska angelikatyborska marked this pull request as ready for review March 27, 2021 15:18
@neenjaw
Copy link
Contributor

neenjaw commented Mar 27, 2021

Looks great!

@angelikatyborska angelikatyborska merged commit bba7aa6 into main Mar 27, 2021
@angelikatyborska angelikatyborska deleted the new-concept-exercise-typespecs branch March 27, 2021 15:59
@angelikatyborska angelikatyborska mentioned this pull request Apr 10, 2021
Closed
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neenjaw neenjaw neenjaw approved these changes

Assignees

No one assigned

Labels

x:size/large Large amount of work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@angelikatyborska @neenjaw @ErikSchierboom