Make practice exercise authors optional #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaMann
reviewed
Mar 23, 2021
|
|
||
| This file contains meta information on the exercise: | ||
|
|
||
| - `authors`: The exercise's author(s) (required) |
There was a problem hiding this comment.
What about making them optional for historic reasons but required for any newly added practice exercise?
I don't know if that's easy to check with configlet, but for the purposes of building a track, i.e. adding new (practice) exercises, they should probably still be required?
There was a problem hiding this comment.
I don't know if that's easy to check with configlet
I'd have to think this through.
There was a problem hiding this comment.
We'll postpone a decision on how to enforce authors for later.
iHiD
approved these changes
Mar 23, 2021
ErikSchierboom
force-pushed
the
optional-authors
branch
from
67e4045 to
266b3ae
Compare
ee7
added a commit
to ee7/exercism-configlet
that referenced
this pull request
Mar 23, 2021
See: - exercism/docs#88 Co-authored-by: Erik Schierboom <[email protected]>
ee7
added a commit
to ee7/exercism-configlet
that referenced
this pull request
Mar 23, 2021
See: - exercism/docs#88 Co-authored-by: Erik Schierboom <[email protected]>
ee7
added a commit
to exercism/configlet
that referenced
this pull request
Mar 23, 2021
This commit also makes `authors` optional for practice exercises. See: - exercism/docs#88 Co-authored-by: Erik Schierboom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't reliably determine authors for all practice exercises, which is why we need to make them optional.