-
-
Notifications
You must be signed in to change notification settings - Fork 96
Disallow a difficulty level of 0 #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ErikSchierboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Difficulty 0 is currently interpreted as being "hard" (which is wrong): https://github.com/exercism/website/blob/main/app/models/exercise.rb#L97
Maybe we should disallow a difficulty of zero, or have it be the required value for deprecated exercises? @iHiD ?
This I think. |
|
@ee7 Could you update the PR? |
f90783c to
d504ffc
Compare
Like this? Do we want |
ErikSchierboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want to make an exception for deprecated exercises, as they can still show up on the website if someone started them before they were deprecated. We'll have to submit some PRs to fix that (easy enough).
|
@ee7 I'm working on a bulk update for the tracks that use difficulty 0. |
Previously, a difficulty value of 0 was allowed, and `configlet lint` checked that each difficulty value was in the range from 0 to 10 inclusive. However, a difficulty of 0 is now disallowed. Typically, exercises with a difficulty value of 0 were deprecated exercises, but these still appear on the website for users who started them before they were deprecated, and so they should still have a difficulty level as normal. With this commit, we change the difficulty of our one deprecated exercise (`binary`) to an allowed value. See: - exercism/docs#290 - exercism/configlet#447
With this commit, `configlet lint` now produces an error if there is a Practice Exercise in the track-level `config.json` file that has a `difficulty` value of `0`. Typically, exercises with such a value were deprecated exercises. However, a deprecated exercise still appears on the website for a user who started that exercise before it was deprecated, and therefore an exercise's difficulty level should not be changed when it is deprecated. We have created a PR on every track that had at least one exercise with a `difficulty` of `0`, updating them to use an allowed value. See: exercism/docs#290
|
@ErikSchierboom Can we merge this? We made |
Edit: updated this PR to disallow difficulty 0 instead.
See below for the list of exercises with a difficulty level of
0. It looks like there is only one (hello-worldon theredtrack) that is not deprecated.Click to expand