anagram: Revise exercise with updates to the specification #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
Stargator
force-pushed
the
bump-anagram
branch
2 times, most recently
from
3e41449 to
afb94eb
Compare
devkabiir
approved these changes
Nov 16, 2019
There was a problem hiding this comment.
Couple of suggestions.
- Prefer
finalandconstwhenever possible. If the variable isn't being reassigned,finalandconstmake it clear at declaration level. However, these are not required for effective dart. There existsprefer_final_localsas well asunnecessary_finallint rules. - Prefer collection literals as per effective_dart style guidelines.
Since these should've been caught when they were introduced, This PR is unrelated, valid and approved.
| test("no matches", () { | ||
| final List<String> result = anagram.findAnagrams("diaper", ["hello", "world", "zombies", "pants"]); | ||
| test('no matches', () { | ||
| final List<String> result = anagram.findAnagrams('diaper', <String>['hello', 'world', 'zombies', 'pants']); |
There was a problem hiding this comment.
<String> type annotation on the list literal is not required. findAnagrams only accepts List as it's second argument. Was this added by the create_exercise tool?
There was a problem hiding this comment.
Same for rest of the list literals in this file.
| Map<String, int> subjectCharsMap = countCharacters(subject); | ||
|
|
||
| List<String> matchTracker = new List<String>(); | ||
| List<String> matchTracker = List<String>(); |
There was a problem hiding this comment.
Suggested change
| List<String> matchTracker = List<String>(); | |
| final List<String> matchTracker = []; |
OR
Suggested change
| List<String> matchTracker = List<String>(); | |
| final matchTracker = <String>[]; |
Stargator
force-pushed
the
bump-anagram
branch
from
afb94eb to
f6206dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #210, ran create_exercise to update anagram and add the version to pubspec.yaml