Skip to content

Conversation

@jacobtomlinson
Copy link
Contributor

Enables the solving of executablebooks/sphinx-book-theme#376 by making the file hash available as a Jinja2 filter.

@welcome
Copy link

welcome bot commented Sep 23, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

This looks helpful to me provided there's no objection from @chrisjsewell 👍

Could you add documentation of this feature? Perhaps here: https://github.com/executablebooks/web-compile#jinja-templates

also see a quick comment from me in the book theme, curious if you've tried that: https://github.com/executablebooks/sphinx-book-theme/pull/397/files#r715196897

@chrisjsewell chrisjsewell changed the title Add hash method to Jinja 👌 IMPROVE: Add hash method to Jinja context Sep 23, 2021
@chrisjsewell chrisjsewell merged commit bfad7cf into executablebooks:master Sep 23, 2021
@welcome
Copy link

welcome bot commented Sep 23, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@chrisjsewell
Copy link
Member

cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants