Skip to content

Conversation

@chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Jun 17, 2021

If spatialaudio/nbsphinx#577 is accepted, this will make the mathjax processing classes the same for both extensions (both override a global variable)
Also improves the warning, and allows it to be suppressed

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #395 (4796b8f) into master (6eba0a9) will increase coverage by 0.35%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   90.30%   90.65%   +0.35%     
==========================================
  Files          14       14              
  Lines        1846     1851       +5     
==========================================
+ Hits         1667     1678      +11     
+ Misses        179      173       -6     
Flag Coverage Δ
pytests 90.65% <88.88%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/main.py 87.50% <ø> (ø)
myst_parser/mathjax.py 95.65% <88.88%> (+15.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eba0a9...4796b8f. Read the comment docs.

@chrisjsewell chrisjsewell merged commit 05d9972 into master Jun 17, 2021
@chrisjsewell chrisjsewell deleted the fix-mathjax-nbsphinx branch June 17, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nbsphinx compatability with mathjax3_config['options']['processHtmlClass'] override

2 participants