Skip to content

Conversation

choldgraf
Copy link
Member

This is an attempt at fixing ipywidgets following the suggestions of @akhmerov...for some reason it still doesn't work though :-/

@akhmerov
Copy link
Contributor

Still this to add?

@choldgraf
Copy link
Member Author

@akhmerov
Copy link
Contributor

Uhhh, maybe this then? :)

@akhmerov
Copy link
Contributor

Or otherwise did you verify that the notebook that you're converting has widget state metadata stored?

@choldgraf
Copy link
Member Author

I believe it does -if I open it up in jupyterlab then the widgets pop back up. I added in the javascript code from the function you mentioned - that definitely should be there either way

@choldgraf
Copy link
Member Author

ugh - OK I think I figured out what the problem is - bootstrap (loaded by the theme we're using) seems to be clashing with RequireJS (required by ipywidgets). It's not related to this codebase at all :-P

I opened up jupyter-widgets/ipywidgets#2787 and pydata/pydata-sphinx-theme#93 to try and spot-check this.

@akhmerov do you know if anybody has gotten jupyter-sphinx to run on a bootstrap-based site?

@choldgraf
Copy link
Member Author

Latest commit should get this working by switching themes to Alabaster, which doesn't have this problem. These docs aren't complex enough yet to warrant a theme like pydata anyway, so we can test on alabaster and spot-check the pydata them problem in another issue

@choldgraf choldgraf merged commit 3d70c84 into master Feb 20, 2020
@chrisjsewell chrisjsewell deleted the state branch March 11, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants