Skip to content

Optimize SlidingWindowGatherer: remove unused finisher and always push current state #18855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize SlidingWindowGatherer: remove unused finisher and always push current state #18855

wants to merge 1 commit into from
+2 −4

Conversation

likhith5697
Copy link

This PR optimizes SlidingWindowGatherer by:

  • Removing the unused finisher() method.
  • Always pushing the current state in integrator() since state.size() never reaches 3.
  • Using ArrayDeque efficiently for O(1) removeFirst operation.

@likhith5697
Copy link
Author

Hi, I’ve implemented the suggested changes:

  • Removed the unused finisher() method.
  • Always pushing the current state in integrator() since state.size() never reaches 3.
  • Using ArrayDeque efficiently for O(1) removeFirst operation.

The build and tests passed successfully. The PR is ready for review: #18855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@likhith5697