This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Remove *args and document #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cations at #etsydoop on IRC
…factoring is going to get messy
… to continue removing *args
…and refactor insert
…immediately. Should re-engineer wrapper around Unique AggregateBy instead.
… compatible change
…ke every raise an exception when aggregator/buffer are mismatched
…ply here, so uniformly use "options" instead
…rbs to nouns for operations
…o avoid confusion when people call cascade/flow constructors
…, which was using the deprecated cascading.cogroup.spill.threshold
…y from contract to clarify; this is a non-backwards compatible change
|
Great work with the documentation, Matt. Loving the examples! |
Author
|
Ha, thanks, they're long overdue. Also, I did this all at one go, so it will likely help to add to the examples during actual use over time, but at least there are now examples to refer to to do so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
This is the start of my upgrade 0.0.10 -> 0.1.0. I believe it primarily changes the contracts of ... most ... DSL methods, removing *args where possible and documenting the heck out of them in general. It also documents the rest of c.j in semi-legible RDoc.
I planned to push this a bit further, but this wound up eating a huge chunk of time because it was so painful to write the documentation. It can likely stand to see some iterations, but it's a start. I also haven't reviewed it very thoroughly, yet.
Next step, for 0.2.0, is to introduce a "Job" and completely break the way c.j works at Etsy =( I'm keeping that back from this PR so you guys can stay on 0.1.0 until you deem it reasonable to go through the effort of porting the Etsy job lib.
Take care,
Matt