Skip to content

Remove unused root property from ConfigurationOption #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Remove unused root property from ConfigurationOption #875

merged 1 commit into from
Apr 7, 2025

Conversation

ZipFile
Copy link
Contributor

@ZipFile ZipFile commented Apr 6, 2025

Replace ConfigurationOption's root property with a method _get_root to avoid name collisions as described in #874.

@ZipFile ZipFile merged commit 4ae79ac into develop Apr 7, 2025
50 of 52 checks passed
@ZipFile ZipFile deleted the remove-unused-configoption-property branch April 7, 2025 11:57
@coveralls
Copy link

Coverage Status

coverage: 94.525% (+0.002%) from 94.523%
when pulling db946de on remove-unused-configoption-property
into 6685c5a on develop.

@ZipFile ZipFile linked an issue May 28, 2025 that may be closed by this pull request
Confusing undocumented behavior of "root" Configuration property name. #874
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing undocumented behavior of "root" Configuration property name.
2 participants
@ZipFile @coveralls