Add ability to call ContractEvents with or without parentheses #3479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes ``filter_by_argument_type``, ``get_name_by_abi_element_identifier``, ``_get_abi_by_signature`` Simplify ``_mismatched_abi_error_diagnosis`` arguments.
…th the event signature
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Sep 16, 2024
|
Closing. This gets handled in #3476 |
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Oct 17, 2024
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Oct 18, 2024
reedsa
added a commit
that referenced
this pull request
Oct 21, 2024
* Contract APIs for event elements in a contract ABI Contract utils for `get_event_by_name`, `get_event_by_signature`, `get_event_by_selector`, `get_event_by_topic` Contract utils for `find_events_by_name`, `find_events_by_signature`, `find_events_by_selector`, `find_events_by_topic` * Newsfragment for #3472 * Apply changes from #3479 * Allow optional parens on events for sync and async contracts * Tests for overlapping function/event names * Corrections per feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #3476, so will need to merge that before merging this.
What was wrong?
ContractEvents were breaking when called as a class method.
Related to Issue #2124
Closes #1648
How was it fixed?
Basically just added a
@combomethoddecorator. @reedsa did the hard work :)Todo:
Cute Animal Picture