Skip to content

Conversation

@DavidRomanovizc
Copy link
Contributor

What was wrong?

Mypy raising error with --no-implicit-reexport flag

Related to Issue #3396
Closes #3396

How was it fixed?

Defining __all__ in __init__.py
Remove noqa

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

@kclowes kclowes mentioned this pull request May 29, 2024
2 tasks
@fselmo
Copy link
Collaborator

fselmo commented May 29, 2024

Thanks @DavidRomanovizc, I didn't see this before submitting #3409. I rebased off of this and opting for that.

@fselmo fselmo closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicitly export symbols via __all__

2 participants