Skip to content

Conversation

@pacrob
Copy link
Contributor

@pacrob pacrob commented Apr 16, 2024

What was wrong?

A single doctest in docs/web3.eth.account.rst fails with eth-account v0.12.0. This disables it.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

@pacrob pacrob force-pushed the camel-snek-messageHash-rawTransaction-v6 branch from ff60700 to d4da7ef Compare April 16, 2024 19:55
@pacrob pacrob force-pushed the camel-snek-messageHash-rawTransaction-v6 branch from 991849b to a09c717 Compare April 16, 2024 21:21
@pacrob pacrob marked this pull request as ready for review April 16, 2024 21:22
@pacrob pacrob requested review from fselmo, kclowes and reedsa April 16, 2024 21:22
@pacrob pacrob changed the title v6 - update uses of messageHash and rawTransaction from eth-account to snakecase version per eth-account v0.12.2 disable doctest that fails with eth-account v0.12.2 Apr 16, 2024
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pacrob pacrob merged commit fef6285 into ethereum:v6 Apr 17, 2024
@pacrob pacrob deleted the camel-snek-messageHash-rawTransaction-v6 branch April 17, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants