Skip to content

[V6] web3exception argument for user_message #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Mar 12, 2024

What was wrong?

Related to #2798
Related to #3094

In #2796 there was a recommendation to add user_message to the Web3Exception class to support hint messages and other information for users.

How was it fixed?

Implemented an optional user_message named argument in Web3Exception. This adds the ability to provide a more human friendly message.

Todo:

Cute Animal Picture

Screen Shot 2024-03-18 at 1 44 36 PM

@reedsa reedsa marked this pull request as ready for review March 14, 2024 15:47
@reedsa reedsa requested review from kclowes, fselmo and pacrob March 14, 2024 15:47
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@reedsa reedsa merged commit 381f98c into ethereum:v6 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants