return default ipc path whether it exists or not #3245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
unconditionally-return-ipc-path
branch
from
0557671 to
cb2372a
Compare
reedsa
reviewed
Feb 23, 2024
| @@ -91,21 +91,15 @@ def get_default_ipc_path() -> Optional[str]: | |||
| ipc_path = os.path.expanduser( | |||
| os.path.join("~", "Library", "Ethereum", "geth.ipc") | |||
| ) | |||
| if os.path.exists(ipc_path): | |||
| return ipc_path | |||
| return None | |||
There was a problem hiding this comment.
I noticed in https://github.com/ethereum/web3.py/pull/2917/files the return None was added to make typing work. I think we can remove the Optional from the return type now that None is being removed.
web3/providers/ipc.py
Outdated
| @@ -91,21 +91,15 @@ def get_default_ipc_path() -> Optional[str]: | |||
| ipc_path = os.path.expanduser( | |||
There was a problem hiding this comment.
Nit: Since these ipc_path vars are not used anywhere else, just return in a single line.
Suggested change
| ipc_path = os.path.expanduser( | |
| return os.path.expanduser( |
reedsa
requested changes
Feb 23, 2024
pacrob
force-pushed
the
unconditionally-return-ipc-path
branch
2 times, most recently
from
316c40b to
e9dfc9b
Compare
pacrob
force-pushed
the
unconditionally-return-ipc-path
branch
from
e9dfc9b to
4b27874
Compare
reedsa
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #2911
Related to Issue #2854
How was it fixed?
Remove check to see if the
.ipcfile exists and just return the default value. Add tests.Also, the default path for
get_default_ipc_pathwas fixed in #3060, but doesn't look like it was forget_dev_ipc_path, so updated that too.Todo:
Cute Animal Picture