fix default windows ipc provider path #3060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
fix-windows-default-ipc-path
branch
from
b23083b to
0c4900e
Compare
pacrob
force-pushed
the
fix-windows-default-ipc-path
branch
from
0c4900e to
bda381f
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
os.path.joinseems to add additional backslashes in py3.11 on windows. I couldn't find a reason/changelog explanation, but at least found someone with the same problem: https://stackoverflow.com/questions/76107858/python-3-10-3-11-changes-on-os-path-joinCloses #3058
How was it fixed?
Changed the default path to
r"\\.\pipe\geth.ipc". Tested against py3.9, 10, and 11 on Windows 10.Updated docs to match geth.
Todo:
Cute Animal Picture