Skip to content

[V6] Estimate Gas with State Override #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Feb 5, 2024

What was wrong?

Related to Issue #3164

How was it fixed?

Adds state_override param to estimate_gas method.

Todo:

Cute Animal Picture

Screen Shot 2024-02-05 at 9 53 55 AM

@reedsa reedsa changed the base branch from main to v6 February 5, 2024 16:54
@reedsa reedsa requested review from fselmo, kclowes and pacrob February 5, 2024 17:13
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is going into stable, it's probably worth a manual check if you haven't already. Once that's been confirmed, this looks good to me!

reedsa added a commit to reedsa/web3.py that referenced this pull request Feb 5, 2024
@reedsa reedsa force-pushed the v6-estimate-gas-state-override branch from 04d8aed to efe1fb6 Compare February 5, 2024 22:18
Update test to pass None for block identifier so geth ignores it, per note in web3.contract.rst

Update description for `state_override`` param in docs

Add async test for `state_override` in estimate gas

Combine logic for eth_call and eth_estimateGas mungers

Mark not implemented in eth tester
@reedsa reedsa force-pushed the v6-estimate-gas-state-override branch from efe1fb6 to 44a6fd5 Compare February 5, 2024 22:23
@reedsa reedsa merged commit 9bcb3c8 into ethereum:v6 Feb 5, 2024
@reedsa reedsa deleted the v6-estimate-gas-state-override branch March 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants