Skip to content

Conversation

@fselmo
Copy link
Collaborator

@fselmo fselmo commented Aug 14, 2023

What was wrong?

How was it fixed?

  • Put the yield in question in an isolated code block by moving the rest of the code into an else as the issue suggests.
  • Re-expose some previously exposed constants related to websockets

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

fselmo added 2 commits August 14, 2023 16:46
- Before refactoring for WbesocketsProviderV2, these constants lived in ``web3/providers/websocket``. Re-expose them via the ``__init__.py`` since "websockets" is now a directory / module.
@fselmo fselmo force-pushed the websockets-bugfixes branch from 47db4ba to 54349cd Compare August 14, 2023 23:47
@fselmo fselmo marked this pull request as ready for review August 15, 2023 00:12
@fselmo fselmo requested review from pacrob, reedsa and wolovim August 15, 2023 00:12
Copy link
Contributor

@dmkulazhenko dmkulazhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 1814b98 into ethereum:main Aug 15, 2023
@fselmo fselmo deleted the websockets-bugfixes branch April 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot import name 'DEFAULT_WEBSOCKET_TIMEOUT'

3 participants