Proper RPC error responses #3061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
force-pushed
the
252-handle-rpc-errors
branch
from
ee911e3 to
8938f76
Compare
kclowes
reviewed
Jul 27, 2023
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
I left a couple comments around the same thing. Let me know if they don't make sense!
| assert result is False | ||
|
|
||
| @pytest.mark.xfail( | ||
| raises=ValueError, reason="list_wallets not implemented in eth-tester" |
| "code": -32601, | ||
| "message": "the method eth_getTransactionByHash does not exist/is not " | ||
| "available", | ||
| "data": MethodUnavailable("method not found"), |
Collaborator
There was a problem hiding this comment.
This is the actual response from a client (in this case Geth) that doesn't implement a method. The data key doesn't get returned, so we can't rely on that to determine which error to throw. We'll want to make this test pass without the data key.
reedsa
commented
Jul 28, 2023
kclowes
approved these changes
Jul 28, 2023
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
I left a few more comments, feel free to take them or leave them!
fselmo
approved these changes
Jul 31, 2023
Collaborator
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
Looks good 👍🏼 . Closer to homogeneity in the eth-tester responses 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When an invalid request is sent to a endpoint that does not exist or hasn't been implemented, the error returned does not comply with the JSON-RPC spec.
Closes ethereum/eth-tester#252
How was it fixed?
Return response objects with required fields for the RPC response.
Raise exception from
error.dataresponse to expose the underlying cause of the issue.Todo:
Cute Animal Picture