Skip to content

Bump and parameterize go version #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Bump and parameterize go version #2900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce19d0e
Parameterize and bump go version for circleci geth jobs
fselmo Mar 28, 2023
0921c30
Clean up old GETH_VERSION passenv in tox.ini
fselmo Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
version: 2.1

parameters:
# Note: update these defaults when updating the geth integration test fixture
geth_version:
# update default value when updating geth integration test fixture
default: "v1.11.5"
type: string
pygeth_version:
# update default value when updating geth integration test fixture
default: "3.12.0"
type: string
go_version:
default: "1.20.2"
type: string

common: &common
working_directory: ~/repo
Expand Down Expand Up @@ -88,8 +92,8 @@ geth_steps: &geth_steps
echo << pipeline.parameters.geth_version >>
export GETH_BINARY="$HOME/.py-geth/geth-<< pipeline.parameters.geth_version >>/bin/geth"
if [ ! -e "$GETH_BINARY" ]; then
curl -O https://storage.googleapis.com/golang/go1.20.1.linux-amd64.tar.gz
tar xvf go1.20.1.linux-amd64.tar.gz
curl -O https://storage.googleapis.com/golang/go<< pipeline.parameters.go_version >>.linux-amd64.tar.gz
tar xvf go<< pipeline.parameters.go_version >>.linux-amd64.tar.gz
sudo chown -R root:root ./go
sudo mv go /usr/local
sudo ln -s /usr/local/go/bin/go /usr/local/bin/go
Expand Down Expand Up @@ -130,8 +134,8 @@ geth_custom_steps: &geth_custom_steps
export GOROOT=/usr/local/go
export GETH_BINARY="./custom_geth"
echo 'export GETH_BINARY="./custom_geth"' >> $BASH_ENV
curl -O https://storage.googleapis.com/golang/go1.20.1.linux-amd64.tar.gz
tar xvf go1.20.1.linux-amd64.tar.gz
curl -O https://storage.googleapis.com/golang/go<< pipeline.parameters.go_version >>.linux-amd64.tar.gz
tar xvf go<< pipeline.parameters.go_version >>.linux-amd64.tar.gz
sudo chown -R root:root ./go
sudo mv go /usr/local
sudo ln -s /usr/local/go/bin/go /usr/local/bin/go
Expand Down
1 change: 1 addition & 0 deletions newsfragments/2900.internal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Bump go version used in CI jobs that install and run go-ethereum and parameterize the version in circleci config file for ease of configuration.
1 change: 0 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ deps =
.[dev]
passenv =
GETH_BINARY
GETH_VERSION
GOROOT
GOPATH
WEB3_INFURA_PROJECT_ID
Expand Down