Add flaky decorator to geth estimate_gas #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
add-flaky-to-tests
branch
from
b67039c to
aa6232e
Compare
kclowes
force-pushed
the
add-flaky-to-tests
branch
from
aa6232e to
11de471
Compare
kclowes
force-pushed
the
add-flaky-to-tests
branch
from
c57fcd5 to
83fcdd4
Compare
kclowes
changed the title
kclowes
added a commit
to kclowes/web3.py
that referenced
this pull request
Apr 11, 2022
* Add flaky decorator to geth gas estimation tests * Add newsfragment
fselmo
pushed a commit
to fselmo/web3.py
that referenced
this pull request
May 2, 2022
* Add flaky decorator to geth gas estimation tests * Add newsfragment (cherry picked from commit 2cd75fd)
fselmo
pushed a commit
to fselmo/web3.py
that referenced
this pull request
May 2, 2022
* Add flaky decorator to geth gas estimation tests * Add newsfragment (cherry picked from commit 2cd75fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Geth integration tests started failing an annoying amount again.
Related to Issue #
How was it fixed?
Added a
flakydecorator with a default of 3 runs. If that doesn't fix it, I think the next step would be do something like:@pytest.mark.xfail(strict=False)I ran the suite a bunch of times and didn't see any failures, so we'll see how it goes.
Todo:
Cute Animal Picture