Add async chain_id setter #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
put-back-async-chain-id
branch
from
952c1d4 to
bec39bf
Compare
|
I wonder if we should have a validation that it can only be set to the edit: Or, alternatively, not even accept a user value, just call the setter to internally set the value to static. Almost like caching but not quite since you can turn it off by setting it back to |
|
I am going to merge this, but like we talked about this morning, I'll check on the original issue to see if there is any reason to allow a different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The new chain_id flow wasn't available on async eth.
Related to Issue #2207
How was it fixed?
Added it!
Todo:
Cute Animal Picture