Skip to content

Please restore chain_id setter (#2376) #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DefiDebauchery opened this issue Jul 18, 2022 · 2 comments
Closed

Please restore chain_id setter (#2376) #2578

DefiDebauchery opened this issue Jul 18, 2022 · 2 comments

Comments

@DefiDebauchery
Copy link
Contributor

In #2376, chain_id was added as a setter. This was a cheap but effective cache to avoid constant lookups during txn building, as simple_cache is not currently async.

There was a discussion about adding some validation, but it may have been an accident that @dbfreem removed it in his subsequent commits in #2432 (as I didn't see any comments about it in that PR). To me, it seems better to have this, even if temporary in a v6.0 branch, and improve upon it later (or become obsoleted by an async version of simple_cache)

@dbfreem
Copy link
Contributor

dbfreem commented Jul 18, 2022

After looking into this for a little while, looks like @kclowes removed this here.

@fselmo
Copy link
Collaborator

fselmo commented Nov 2, 2022

The simple cache middleware has been asynced, via #2579, and will be out in next release.

@fselmo fselmo closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants