Skip to content

asyncify eth.syncing #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2022
Merged

asyncify eth.syncing #2331

merged 1 commit into from
Feb 2, 2022

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Feb 2, 2022 •
edited
Loading

Related to Issue #1413

How was it fixed?

Added async eth.syncing method

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@pacrob pacrob requested review from kclowes and fselmo February 2, 2022 21:14
kclowes
kclowes approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@pacrob pacrob merged commit 99b21f4 into ethereum:master Feb 2, 2022
@pacrob pacrob deleted the asyncify_eth.syncing branch February 2, 2022 21:18
@pmadhikar pmadhikar mentioned this pull request Feb 18, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

@fselmo fselmo Awaiting requested review from fselmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacrob @kclowes