Update web3.pm to use simple solidity registry implementation #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
ethpm-update-registry
branch
from
c97f799 to
3888d9b
Compare
njgheorghita
force-pushed
the
ethpm-update-registry
branch
from
3888d9b to
e096f10
Compare
pipermerriam
approved these changes
Jul 24, 2019
Member
pipermerriam
left a comment
pipermerriam
left a comment
There was a problem hiding this comment.
This is very rubber-stampy. Mostly just glanced at the diff structurally since this appears to be primarily just a rework of existing logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The Vyper implementation is not quite ERC1319 compliant, and might not be for the near future. So, I updated
web3.pmto use the new, simplified solidity implementation as its default registry.I got rid of the
VyperReferenceRegistryfor now, since it's not needed, and can be easily added back in once Vyper is capable of supporting an ERC1319 interface.Cute Animal Picture