[ethPM] web3.pm management #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
web3-pm-management
branch
from
2963cb6 to
39139cd
Compare
njgheorghita
force-pushed
the
web3-pm-management
branch
from
39139cd to
e50470e
Compare
njgheorghita
force-pushed
the
web3-pm-management
branch
from
f9ea5cf to
c4c5f57
Compare
Contributor
Author
|
merging since this is a minor cosmetic pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
If
web3.pmis already enabled - trying to re-enable (viaw3.enable_unstable_package_management_api) raises an error (cannot attach an attribute that's already been attached), this can cause problems when usingweb3.auto.infura.w3but now it silently continues about its business.Also..
ethpm'sValidationErrortoEthPMValidationErrorto avoid confusion withweb3'sValidationErrorCute Animal Picture