Skip to content

Add Nodesmith auto-provider #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add Nodesmith auto-provider #1300

wants to merge 5 commits into from

Conversation

sdesmond46
Copy link

@sdesmond46 sdesmond46 commented Mar 26, 2019

What was wrong?

Nodesmith is a new JSON RPC service which provides access to hosted nodes. This change adds a Nodesmith auto-provider which can be used to interact with Ethereum networks.

Related to Issue: N/A

How was it fixed?

Added a new provider and unit tests for it.
Also added a goerli provider for Infura.

Cute Animal Picture

DogChain

@pipermerriam
Copy link
Member

I wasn't aware of your service. I think we will want to have a discussion about this type of functionality. For some context.

  • Infura was added back when it was largely the only option of it's kind.
  • Adding more is likely to set a precedent that I'm hesitant about as more cloud providers show up.
  • I still like users having an easy way for quick direct connection like this.
  • I am not keen on the maintenance overhead that this will result in as recently seen by infura's change to require API keys.

@sdesmond46
Copy link
Author

I wasn't aware of your service. I think we will want to have a discussion about this type of functionality. For some context.

  • Infura was added back when it was largely the only option of it's kind.
  • Adding more is likely to set a precedent that I'm hesitant about as more cloud providers show up.
  • I still like users having an easy way for quick direct connection like this.
  • I am not keen on the maintenance overhead that this will result in as recently seen by infura's change to require API keys.

Thanks for taking a look at the PR! We definitely understand the hesitation to set a precedent which could require future maintenance, but we do think it's important for people to have clear options and alternatives. We're happy to provide give feedback on and help implement any new patterns for getting new cloud providers included in the library.

@fubuloubu
Copy link
Contributor

Maybe there's a way to abstract out a "websocket provider" that packages can be built for separately from the web3 library, but can hook in easily as a provider option. Same with Infura (just switch them out e.g. pip install web3-nodesmith-provider)

@wolovim
Copy link
Member

wolovim commented Sep 18, 2020

Confirming that 3rd-party packages will be the future of auto-providers. Related issue: #1736.

@wolovim wolovim closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants