Update Parity version for integration testing to 2.3.5 #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
upgrade-parity
branch
8 times, most recently
from
96830b6 to
75bf7c8
Compare
njgheorghita
changed the title
kclowes
approved these changes
Mar 20, 2019
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Looks good! Thanks for picking this up!
| '--jsonrpc-apis', 'all', | ||
| '--jsonrpc-port', parity_port, | ||
| '--fat-db', 'on', | ||
| # '--author', common.COINBASE[2:], |
Collaborator
There was a problem hiding this comment.
I think we can probably get rid of this
| '--jsonrpc-apis', 'all', | ||
| '--jsonrpc-port', parity_port, | ||
| '--fat-db', 'on', | ||
| # '--author', common.COINBASE[2:], |
Collaborator
There was a problem hiding this comment.
Same here, let's get rid of this
kclowes
approved these changes
Mar 20, 2019
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
Collaborator
|
Ha, forgot I had already submitted my review. Double approval! |
njgheorghita
force-pushed
the
upgrade-parity
branch
from
75bf7c8 to
317c083
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Updated Parity version to 2.3.5 for integration tests
.travis.yml1.8.7and1.8.8Cute Animal Picture