Relocate eth_protocolVersion and web3_clientVersion #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Now that |
njgheorghita
force-pushed
the
relocate-eth_protocolVersion
branch
4 times, most recently
from
a9a3176 to
6f03c1d
Compare
njgheorghita
force-pushed
the
relocate-eth_protocolVersion
branch
from
6f03c1d to
e0ec4ac
Compare
kclowes
approved these changes
Mar 12, 2019
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Looks good to me @njgheorghita!
| @@ -0,0 +1,2 @@ | |||
| def test_eth_protocolVersion(web3): | |||
| assert web3.eth.protocolVersion == '99' | |||
Member
There was a problem hiding this comment.
I believe it's talking to eth-tester and should probably be updated internally to be 63
Contributor
Author
There was a problem hiding this comment.
Hmmm, strange - according to this line it should be returning 63. Will dive deeper into this tomorrow
kclowes
reviewed
Mar 18, 2019
| .. code-block:: python | ||
| >>> web3.version.node | ||
| >>> web3.clientVersion |
Collaborator
There was a problem hiding this comment.
I know this is merged already, but I noticed that there isn't documentation for web3.clientVersion. Do you mind adding it when you get a chance? 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth_protocolVersionendpoint fromweb3.version.ethereumtoweb3.eth.protocolVersionweb3_clientVersionendpoint fromweb3.version.nodetoweb3.clientVersionUpon approval of this pr, I'll create a pr to raise deprecation warnings in v4
Cute Animal Picture