Migrate tester provider results from middleware to defaults #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Great. I'll continue with the rest. Not ready to merge until the following are complete:
|
dylanjw
force-pushed
the
eth_tester_defaults
branch
from
3647a50 to
6c974f5
Compare
pipermerriam
approved these changes
Jan 8, 2019
Member
pipermerriam
left a comment
pipermerriam
left a comment
There was a problem hiding this comment.
This looks 👍 to merge assuming it is complete.
Contributor
Author
|
This is ready to merge. I am going to work on the request parameter formatters and the transaction fields middleware in separate pull requests. |
Member
|
@dylanjw you should not have merge rights. |
Contributor
Author
|
Assuming piper meant 'now' instead of 'not', in case anyone reading this PR thinks Im out of control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Many of default results for the EthereumTesterProvider come from a set of special middlewares. Eliminating these middlewares will reduce the number of middlewares that need to be duplicated for async support. Having these middlewares eliminated will also help with testing the early stages of the async api, which implements no middlewares.
Before I get too far with this, does this seem like an acceptable way forward? Should I continue eliminating the rest of the eth_tester middlewares? is there any reason that these results and formatters need the middleware pattern? Removing them does not preclude using custom middlewares to alter the EthereumTesterProvider defaults.
Cute Animal Picture