converted Web3 instance variables to 'w3'. #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Test failures appear unrelated. |
Contributor
Author
|
Question: In the overview.rst file, should I also change Web3 in the convenience methods to w3? I'm not sure because they appear to be class methods. |
Contributor
Author
|
I see that web3 is used as the variable for instances of web3 in many of the .py files. Shall I take a crack at changing these as well? |
pipermerriam
approved these changes
Jan 9, 2019
kclowes
pushed a commit
to pjryan93/web3.py
that referenced
this pull request
Apr 25, 2019
* converted Web3 instance variables to 'w3'. * changed web3 instances to w3 * changed web3 instance variables to w3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1183
How was it fixed?
I made changes to one file "web3.docs.internals.rst". I wanted to begin a pull request to confirm I'm making changes in the correct way before continuing on to other files. (This will be my first issue ;)
Cute Animal Picture