Skip to content

Conversation

@freeatnet
Copy link
Contributor

@freeatnet freeatnet commented Nov 25, 2018

What was wrong?

websockets doesn't send pings to keep the connection open.

How was it fixed?

Upgraded websockets to 7.0, which has keepalive support out of the box.

Full changelog here.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an easy fix.

@carver carver merged commit 1fea824 into ethereum:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants