Update provider explicit exports #3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fselmo
force-pushed
the
update-provider-explicit-exports
branch
from
42ef2c6 to
ffbc5c9
Compare
fselmo
force-pushed
the
update-provider-explicit-exports
branch
2 times, most recently
from
f9b7f21 to
0e4b0c3
Compare
Collaborator
Author
Ah, I missed that PR. Yeah, I think that's nice to have. I will rebase off of it and add the missing exports after the fact. |
* Require eth-account 0.13.x to get doctests passing * Fix eth-account doctests * Move signHash -> unsafe_sign_hash * Add newsfragment
- Adds AsyncEthereumTesterProvider to web3/__init__.py. - Adds EthereumTesterProvider and AsyncEthereumTesterProvider to web3/providers/__init__.py. - Update __all__ in web3/__init__.py to include all provider classes, including base classes. - Add __all__ for web3/providers/__init__.py including all explicit exports.
fselmo
force-pushed
the
update-provider-explicit-exports
branch
from
0e4b0c3 to
fb3aa01
Compare
Collaborator
Author
Collaborator
|
No, I don't think we want to re-export |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #3396 together with #3410
How was it fixed?
AsyncEthereumTesterProviderto web3/__init__.py.EthereumTesterProviderandAsyncEthereumTesterProviderto web3/providers/__init__.py.__all__in web3/__init__.py to include all provider classes, including base classes.__all__for web3/providers/__init__.py including all explicit exports.Todo:
Cute Animal Picture