Refactor geth steps to use correct py-geth version #2898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
geth-steps-refactor
branch
3 times, most recently
from
cfa6a06 to
c092b96
Compare
fselmo
force-pushed
the
geth-steps-refactor
branch
from
c092b96 to
cd806cf
Compare
fselmo
changed the title
- Make sure pip is up to date
- Use quotes for pip install with minimum version ``pip install --user "py-geth>={version}"`` (https://pip.pypa.io/en/stable/cli/pip_install/#examples)
fselmo
force-pushed
the
geth-steps-refactor
branch
from
cd806cf to
44817d4
Compare
pacrob
approved these changes
Mar 28, 2023
Contributor
pacrob
left a comment
pacrob
left a comment
There was a problem hiding this comment.
lgtm, based on discussion about separate PR for borked windows build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
How was it fixed?
Alternative:
Just use
pip install --user py-geth=={version}Note:
The windows wheel build just started failing on this PR. I'm going to address that in a separate PR, so please ignore that failing CI build and it should still fail on
masteruntil we get the fix in.Todo:
Cute Animal Picture