Skip to content

Commit cd806cf

Browse files
committed
Refactor geth steps to pip install correct py-geth version
- Make sure pip is up to date - Use quotes for pip install with minimum version ``pip install --user "py-geth>={version}"`` (https://pip.pypa.io/en/stable/cli/pip_install/#examples)
1 parent 7592e98 commit cd806cf

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.circleci/config.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,14 @@ geth_steps: &geth_steps
7676
- cache-{{ .Environment.CIRCLE_JOB }}-{{ checksum "setup.py" }}-{{ checksum "tox.ini" }}
7777
- run:
7878
name: install dependencies
79-
command: pip install --user tox
79+
command: |
80+
pip install --upgrade pip
81+
pip install --user tox
8082
- run:
8183
name: build geth if missing
8284
command: |
8385
mkdir -p $HOME/.ethash
84-
pip install --user py-geth>=<< pipeline.parameters.pygeth_version >>
86+
pip install --user "py-geth>=<< pipeline.parameters.pygeth_version >>"
8587
export GOROOT=/usr/local/go
8688
echo << pipeline.parameters.geth_version >>
8789
export GETH_BINARY="$HOME/.py-geth/geth-<< pipeline.parameters.geth_version >>/bin/geth"

newsfragments/2898.internal.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Update ``geth_steps`` in CircleCI builds to pip install the proper version of ``py-geth``.gs
2+

0 commit comments

Comments
 (0)