Add windows CI run, and update circleci version #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
windows-ci
branch
11 times, most recently
from
c9fcfaf to
434aba7
Compare
kclowes
changed the title
wolovim
approved these changes
Mar 22, 2021
Member
wolovim
left a comment
wolovim
left a comment
There was a problem hiding this comment.
Thanks for diving down the rabbit hole 🐰
Checking my understanding, the wheel tests are primarily a smoke test to verify that the lib will build for a given environment and can be imported? If accurate, looks like a good checkpoint.
Collaborator
Author
|
@marcgarreau Yep, exactly. Making sure we don't have any errors when installing in a fresh env and that we can import our web3 instance! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We didn't have any windows testing in CI.
Related to Issue #1892, #166, #1742
How was it fixed?
Added windows to our CI. I couldn't figure out how to test against different versions of Python in windows, so we're currently only testing against Python 3.7.
Also did some caching cleanup, and had to update the CircleCI version.
Todo:
Cute Animal Picture