Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

cburgdorf
Copy link
Contributor

@cburgdorf cburgdorf commented Jun 21, 2018

What was wrong?

Mypy was on an outdated version.

How was it fixed?

Updated to 0.610 but disabled the strict-optional check for now as our code base does not pass it yet.

Mypy highlights for that new version

  • reveal_locals()
  • The type of the object returned by calling an async function used to be Awaitable; it’s changed to Coroutine since such objects support calling send() and throw() on them

More in the blog post

Cute Animal Picture

put a cute animal picture link inside the parentheses

@cburgdorf cburgdorf force-pushed the christoph/chore/upgrade-mypy branch from daaafca to 23a0ae9 Compare June 21, 2018 11:36
@pipermerriam pipermerriam merged commit 010846c into ethereum:master Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants