This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Handle AlreadyWaiting condition during discovery node lookup #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
force-pushed
the
piper/handle-AlreadyWaiting-during-discovery-node-lookup
branch
2 times, most recently
from
b2c8ded to
d71c4d6
Compare
pipermerriam
force-pushed
the
piper/handle-AlreadyWaiting-during-discovery-node-lookup
branch
from
d71c4d6 to
ced9516
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #762
What was wrong?
Unhandled exception case during discovery node lookup.
How was it fixed?
Do a pre-filter on the list of nodes to remove any for which we're already waiting for a response.
Also moved the removal of the callback into a
finallyblock to be sure it doesn't get skipped.Cute Animal Picture