Unify ValidationError
#1194
Unify ValidationError
#1194
Conversation
setup.py
Outdated
| "eth-keys>=0.2.0b3,<1.0.0", | ||
| "eth-typing>=1.1.0,<2.0.0", | ||
| "eth-utils>=1.0.1,<2.0.0", | ||
| "eth-utils==1.1.1", |
There was a problem hiding this comment.
Why the pin to a specific version here?
glaksmono
force-pushed
the
eth-py-evm-1125
branch
2 times, most recently
from
c7a51a4 to
d862104
Compare
glaksmono
force-pushed
the
eth-py-evm-1125
branch
from
d862104 to
bdbac0a
Compare
pipermerriam
left a comment
pipermerriam
left a comment
There was a problem hiding this comment.
I didn't comment on all of them but can you go and move the eth_utils imports to be above the eth imports. We like to ensure our imports are grouped by namespace.
eth/chains/shard.py
Outdated
| ) | ||
|
|
||
| from eth.exceptions import ( | ||
| from eth_utils import ( |
There was a problem hiding this comment.
This import should move up above the previous import so that all of the eth imports remain in the same block.
eth/consensus/pow.py
Outdated
| encode_hex, | ||
| ) | ||
| from eth.exceptions import ( | ||
| from eth_utils import ( |
There was a problem hiding this comment.
Same here, move it up above the eth imports
|
|
||
| from eth import constants | ||
| from eth.exceptions import ( | ||
| from eth_utils import ( |
There was a problem hiding this comment.
This should move up above the eth imports
trinity/sync/common/chain.py
Outdated
| HeaderNotFound, | ||
| ValidationError as EthValidationError, | ||
| ) | ||
| from eth_utils import ValidationError as EthValidationError |
There was a problem hiding this comment.
You can drop this rename and just change all of the places where EthValidationError is raised to just be a ValidationError.
glaksmono
force-pushed
the
eth-py-evm-1125
branch
from
79e16ef to
d18b78e
Compare
3 participants
What was wrong?
https://github.com/ethereum/py-evm/pull/1089/files#r206404376
As noted in this comment, there is a valid concern that our duplicate
ValidationErrorexceptions could easily be mixed up, causing us to not be catching the exception we think we are catching.Issue Reference: #1125
How was it fixed?
Modify the codebase to use that exception class for all
ValidationErrorexceptions to use the one frometh_utilsCute Animal Picture