Unify ValidationError
#1194
Merged
Unify ValidationError
#1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
reviewed
Aug 18, 2018
setup.py
Outdated
| @@ -10,7 +10,7 @@ | |||
| "eth-bloom>=1.0.0,<2.0.0", | |||
| "eth-keys>=0.2.0b3,<1.0.0", | |||
| "eth-typing>=1.1.0,<2.0.0", | |||
| "eth-utils>=1.0.1,<2.0.0", | |||
| "eth-utils==1.1.1", | |||
There was a problem hiding this comment.
Why the pin to a specific version here?
glaksmono
force-pushed
the
eth-py-evm-1125
branch
2 times, most recently
from
c7a51a4 to
d862104
Compare
glaksmono
force-pushed
the
eth-py-evm-1125
branch
from
d862104 to
bdbac0a
Compare
pipermerriam
suggested changes
Aug 18, 2018
eth/chains/shard.py
Outdated
| @@ -10,7 +10,7 @@ | |||
| ShardDB, | |||
| ) | |||
|
|
|||
| from eth.exceptions import ( | |||
| from eth_utils import ( | |||
There was a problem hiding this comment.
This import should move up above the previous import so that all of the eth imports remain in the same block.
eth/consensus/pow.py
Outdated
| @@ -19,7 +19,7 @@ | |||
| from eth.utils.hexadecimal import ( | |||
| encode_hex, | |||
| ) | |||
| from eth.exceptions import ( | |||
| from eth_utils import ( | |||
There was a problem hiding this comment.
Same here, move it up above the eth imports
eth/precompiles/ecmul.py
Outdated
| @@ -3,8 +3,10 @@ | |||
| ) | |||
|
|
|||
| from eth import constants | |||
| from eth.exceptions import ( | |||
| from eth_utils import ( | |||
There was a problem hiding this comment.
This should move up above the eth imports
trinity/sync/common/chain.py
Outdated
| @@ -14,13 +14,16 @@ | |||
| from eth.chains import AsyncChain | |||
| from eth.exceptions import ( | |||
| HeaderNotFound, | |||
| ValidationError as EthValidationError, | |||
| ) | |||
| from eth_utils import ValidationError as EthValidationError | |||
There was a problem hiding this comment.
You can drop this rename and just change all of the places where EthValidationError is raised to just be a ValidationError.
glaksmono
force-pushed
the
eth-py-evm-1125
branch
from
79e16ef to
d18b78e
Compare
pipermerriam
approved these changes
Aug 20, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
https://github.com/ethereum/py-evm/pull/1089/files#r206404376
As noted in this comment, there is a valid concern that our duplicate
ValidationErrorexceptions could easily be mixed up, causing us to not be catching the exception we think we are catching.Issue Reference: #1125
How was it fixed?
Modify the codebase to use that exception class for all
ValidationErrorexceptions to use the one frometh_utilsCute Animal Picture