Skip to content

Add back benchmarking tests #2046

@kclowes

Description

@kclowes

What is wrong?

The benchmarking tests are failing because of a dependency resolution error with web3.py's typing-extensions dep. It's going to take a bit to get the dependencies resolved, and I want to get Arrow Glacier support in sooner than later. Performance is less important now than it was when trinity was using py-evm to be a mainnet client. I took out the benchmarking CI run in PR #2040. This test run has the dependency resolution chain: https://app.circleci.com/pipelines/github/ethereum/py-evm/2053/workflows/465fee73-0b8f-47b6-9ae9-7e45803c4dad/jobs/155952.

How can it be fixed

Loosen typing-extension dependency restrictions in web3.py and then release. See: ethereum/web3.py#2217

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions