simulators/ethereum/engine: Update/Verify LatestValidHash in more tests #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Included
Verify LatestValidHash in all
engine_newPayloadV1callsAdds verification and fixes existing verifications of LatestValidHash in all
engine_newPayloadV1calls.According to ethereum/execution-apis#254, this line is not verified by any hive tests yet:
In the context of an
INVALIDpayload.Print Caller of "Expect*" Functions on Failure
Test now prints the calling file/line on failure of any "Expect*" function.