crypto/keccak: vendor in golang.org/x/crypto/sha3 #33323
+6,393
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream libray has removed the assembly-based implementation of keccak. We need to maintain our own library to avoid a peformance regression.
fjl
force-pushed
the
crypto-keccak-vendoring
branch
from
2d97756 to
43863ae
Compare
fjl
requested review from
MariusVanDerWijden,
lightclient,
rjl493456442 and
zsfelfoldi
as code owners
gballet
reviewed
Nov 30, 2025
Member
gballet
left a comment
gballet
left a comment
There was a problem hiding this comment.
Should both go.mod not be updated in order to remove the reference to the other package?
Contributor
Author
|
We use some other packages from golang.org/x/crypto still |
|
Since go-ethereum isn't the only project impacted by this (Filecoin is too, there's likely many more), perhaps a separate repo to maintain the extracted package would be good? It could even be a shared concern among those of us that depend on it so we can collectively maintain it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream libray has removed the assembly-based implementation of keccak. We need to maintain our own library to avoid a peformance regression.