build, internal, version: break ci.go/version->common dependency #30638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
requested review from
fjl,
holiman,
gballet,
rjl493456442,
zsfelfoldi and
lightclient
as code owners
karalabe
force-pushed
the
cigo-dep-clean
branch
from
6df0439 to
439caf2
Compare
karalabe
force-pushed
the
cigo-dep-clean
branch
from
439caf2 to
366b884
Compare
zfy0701
pushed a commit
to sentioxyz/go-ethereum
that referenced
this pull request
Dec 3, 2024
…ereum#30638) This PR tries to break the ci.go to common dependency by moving the version number out of params.
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
…ereum#30638) This PR tries to break the ci.go to common dependency by moving the version number out of params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to break the ci.go to common dependency by moving the version number out of params.