Skip to content

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Oct 12, 2024

Changelog: https://golangci-lint.run/product/changelog/#1610

Removes exportloopref (no longer needed), replaces it with copyloopvar which is basically the opposite.

Also adds:

  • durationcheck
  • gocheckcompilerdirectives
  • reassign
  • mirror
  • tenv

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we could add even more linters.
I made a PR to this one here: holiman#59

@holiman holiman added this to the 1.14.12 milestone Oct 14, 2024
@holiman holiman merged commit 5adc314 into ethereum:master Oct 14, 2024
3 checks passed
holiman added a commit that referenced this pull request Nov 19, 2024
Changelog: https://golangci-lint.run/product/changelog/#1610 

Removes `exportloopref` (no longer needed), replaces it with
`copyloopvar` which is basically the opposite.

Also adds: 
- `durationcheck`
- `gocheckcompilerdirectives`
- `reassign`
- `mirror`
- `tenv`

---------

Co-authored-by: Marius van der Wijden <[email protected]>
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 24, 2025
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Jun 23, 2025
gzliudan pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Jul 1, 2025
jakub-freebit pushed a commit to fblch/go-ethereum that referenced this pull request Jul 3, 2025
Changelog: https://golangci-lint.run/product/changelog/#1610 

Removes `exportloopref` (no longer needed), replaces it with
`copyloopvar` which is basically the opposite.

Also adds: 
- `durationcheck`
- `gocheckcompilerdirectives`
- `reassign`
- `mirror`
- `tenv`

---------

Co-authored-by: Marius van der Wijden <[email protected]>
gballet pushed a commit to gballet/go-ethereum that referenced this pull request Sep 11, 2025
Changelog: https://golangci-lint.run/product/changelog/#1610 

Removes `exportloopref` (no longer needed), replaces it with
`copyloopvar` which is basically the opposite.

Also adds: 
- `durationcheck`
- `gocheckcompilerdirectives`
- `reassign`
- `mirror`
- `tenv`

---------

Co-authored-by: Marius van der Wijden <[email protected]>
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2025
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants