params: print time value instead of pointer in ConfigCompatError #29514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
force-pushed
the
fix_print_ConfigCompatError
branch
from
d05595c to
05bd185
Compare
Contributor
Author
|
failed test cases not related |
holiman
reviewed
Apr 16, 2024
Contributor
Author
|
@holiman hi, updated as you suggested and a UT added. |
NathanBSC
force-pushed
the
fix_print_ConfigCompatError
branch
from
9e861d3 to
2baaa72
Compare
fjl
changed the title
fjl
approved these changes
Apr 30, 2024
Dayday10
approved these changes
May 8, 2024
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
darioush
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Oct 1, 2024
ARR4N
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Oct 29, 2024
…ereum#29514) Cherry-pick of `69f815f6f5791e0e48160bdad284773d0ffb1ba9`.
darioush
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Nov 21, 2024
…ereum#29514) Cherry-pick of `69f815f6f5791e0e48160bdad284773d0ffb1ba9`.
ARR4N
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Nov 29, 2024
…ereum#29514) Cherry-pick of `69f815f6f5791e0e48160bdad284773d0ffb1ba9`.
darioush
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Jan 13, 2025
…ereum#29514) Cherry-pick of `69f815f6f5791e0e48160bdad284773d0ffb1ba9`.
qdm12
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Feb 14, 2025
ARR4N
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Feb 17, 2025
ARR4N
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Feb 17, 2025
github-merge-queue bot
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Mar 17, 2025
## Why this should be merged Safer release process by enforcing invariants of `release/*` branches as automated in #137 to fulfil #25. ## How this works New test for `go_tooling` CI job. If the PR target branch is `main` then only the `params.ReleaseType` is checked. If the target is neither `main` nor a release branch then the test is skipped. The checks performed on `release/*` branches are described in the test. ## How this was tested Locally against a dummy release branch with deliberate problems created by (a) including this PR's changes in the final commit and (b) not updating the libevm version. ``` $ go test -v ./... --target_branch="release/v1.13.14-0.1.0.rc.3" === RUN TestCherryPicksFormat --- PASS: TestCherryPicksFormat (0.39s) === RUN TestBranchProperties === RUN TestBranchProperties/branch_name release_test.go:172: Error Trace: .../ava-labs/libevm/libevm/tooling/release/release_test.go:172 Error: Not equal: expected: "release/v1.13.14-0.1.0.beta" actual : "release/v1.13.14-0.1.0.rc.3" Diff: --- Expected +++ Actual @@ -1 +1 @@ -release/v1.13.14-0.1.0.beta +release/v1.13.14-0.1.0.rc.3 Test: TestBranchProperties/branch_name release_test.go:175: On release branch; params.LibEVMReleaseType = "beta", which is unsuitable for release branches === RUN TestBranchProperties/commit_history release_test.go:192: Forked from "main" at commit 4c6e50e (chore: module-renaming workflow inverts between `libevm` and `geth` (#152)) release_test.go:314: ### History since fork from default branch (8 commits): release_test.go:316: internal/build, rpc: add missing HTTP response body Close() calls (ethereum#29223) by Shiming Zhang <[email protected]> release_test.go:316: core/state: fix bug in statedb.Copy and remove unnecessary preallocation (ethereum#29563) by Aaron Chen <[email protected]> release_test.go:316: params: print time value instead of pointer in ConfigCompatError (ethereum#29514) by Nathan <[email protected]> release_test.go:316: eth/gasprice: add query limit for FeeHistory to defend DDOS attack (ethereum#29644) by Nathan <[email protected]> release_test.go:316: core/state/snapshot: add a missing lock (ethereum#30001) by maskpp <[email protected]> release_test.go:316: crypto: add IsOnCurve check (ethereum#31100) by Felix Lange <[email protected]> release_test.go:316: internal/ethapi: fix panic in debug methods (ethereum#31157) by Sina M <[email protected]> release_test.go:316: x by Arran Schlosberg <[email protected]> === RUN TestBranchProperties/commit_history/cherry_picked_commits release_test.go:314: ### Expected cherry-picks (7 commits): release_test.go:316: internal/build, rpc: add missing HTTP response body Close() calls (ethereum#29223) by Shiming Zhang <[email protected]> release_test.go:316: core/state: fix bug in statedb.Copy and remove unnecessary preallocation (ethereum#29563) by Aaron Chen <[email protected]> release_test.go:316: params: print time value instead of pointer in ConfigCompatError (ethereum#29514) by Nathan <[email protected]> release_test.go:316: eth/gasprice: add query limit for FeeHistory to defend DDOS attack (ethereum#29644) by Nathan <[email protected]> release_test.go:316: core/state/snapshot: add a missing lock (ethereum#30001) by maskpp <[email protected]> release_test.go:316: crypto: add IsOnCurve check (ethereum#31100) by Felix Lange <[email protected]> release_test.go:316: internal/ethapi: fix panic in debug methods (ethereum#31157) by Sina M <[email protected]> === RUN TestBranchProperties/commit_history/final_commit release_test.go:365: Modified disallowed file "go.yml" release_test.go:365: Modified disallowed file "go.mod" release_test.go:365: Modified disallowed file "go.sum" release_test.go:365: Modified disallowed file "release_test.go" --- FAIL: TestBranchProperties (2.07s) --- FAIL: TestBranchProperties/branch_name (0.00s) --- FAIL: TestBranchProperties/commit_history (2.07s) --- PASS: TestBranchProperties/commit_history/cherry_picked_commits (1.81s) --- FAIL: TestBranchProperties/commit_history/final_commit (0.01s) FAIL FAIL github.com/ava-labs/libevm/libevm/tooling/release 2.712s FAIL ```
qdm12
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Mar 26, 2025
ceyonur
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Apr 10, 2025
ceyonur
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Apr 11, 2025
ARR4N
pushed a commit
to ava-labs/libevm
that referenced
this pull request
Jun 10, 2025
ARR4N
added a commit
to ava-labs/libevm
that referenced
this pull request
Oct 18, 2025
…ror (ethereum#29514)" This reverts commit b570d5e.
ARR4N
added a commit
to ava-labs/libevm
that referenced
this pull request
Oct 19, 2025
…ror (ethereum#29514)" This reverts commit b570d5e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two errors in func ConfigCompatError as error info in the above picture
RewindToTime overflow
for dev testnet, often set timebased hardfork to
0, so they will be enabled same with London Block at genesisfor example in genesis.json
"shanghaiTime": 0,then we change it
"shanghaiTime": 1712889032,and run `geth --datadir ./ init ./genesis.json, then RewindToTime will overflow to the max of uint64 type
err.StoredTime and err.NewTime are pointers, print them is meaningless, their value are desired