Skip to content

p2p/dnsdisc: using clear builtin func #29418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2024
Merged

p2p/dnsdisc: using clear builtin func #29418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83d49e8
p2p/dnsdisc: using clear builtin func
cuiweixie Apr 1, 2024
b2a7189
p2p/dnsdisc: use clear directly
fjl Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions p2p/dnsdisc/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func TestIteratorNodeUpdates(t *testing.T) {
// Ensure RandomNode returns the new nodes after the tree is updated.
updateSomeNodes(keys, nodes)
tree2, _ := makeTestTree("n", nodes, nil)
resolver.clear()
clear(resolver)
resolver.add(tree2.ToTXT("n"))
t.Log("tree updated")

Expand Down Expand Up @@ -256,7 +256,7 @@ func TestIteratorRootRecheckOnFail(t *testing.T) {
// Ensure RandomNode returns the new nodes after the tree is updated.
updateSomeNodes(keys, nodes)
tree2, _ := makeTestTree("n", nodes, nil)
resolver.clear()
clear(resolver)
resolver.add(tree2.ToTXT("n"))
t.Log("tree updated")

Expand Down Expand Up @@ -447,12 +447,6 @@ func newMapResolver(maps ...map[string]string) mapResolver {
return mr
}

func (mr mapResolver) clear() {
for k := range mr {
delete(mr, k)
}
}

func (mr mapResolver) add(m map[string]string) {
maps.Copy(mr, m)
}
Expand Down