core/txpool/legacypool: protect cache with mutex #27898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
force-pushed
the
txpool_list_mutex
branch
from
ccb1318 to
a4354d4
Compare
rjl493456442
approved these changes
Aug 17, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This change fixes the a potential race by using mutexes when the m.cache is read or modified.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
)" This reverts commit 10133ba.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
)" This reverts commit 10133ba.
pdrobnjak
pushed a commit
to Tenderly/net-scroll-geth
that referenced
this pull request
Apr 30, 2025
* upgrade rlp to go-ethereum v.14.6 * core/types: transaction and receipt encoding/decoding optimizations ethereum#27976 * core/types: use new atomic types in caches ethereum#29411, fix eth/handler bug * eth/fetcher: throttle peers which deliver many invalid transactions ethereum#25573 * core: preallocate map in tx_pool ethereum#25737 * core/txpool: protect cache with mutex ethereum#27898 * upgrade memsize to v0.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pr #27324 fixed an issue somewhat incidentally. This PR fixes the root issue a bit more robustly, by using mutexes when the cache is read or modified.
Replaces #27324