Skip to content

Conversation

@lightclient
Copy link
Member

@lightclient lightclient commented Nov 18, 2021

These should default to false since they're later inverted:

logConfig := &vm.LogConfig{
DisableStack: ctx.Bool(TraceDisableStackFlag.Name),
EnableMemory: !ctx.Bool(TraceDisableMemoryFlag.Name),
EnableReturnData: !ctx.Bool(TraceDisableReturnDataFlag.Name),
Debug: true,
}

@holiman
Copy link
Contributor

holiman commented Nov 19, 2021

BoolTFlag

BoolTFlag is a flag with type bool that is true by default

As opposed to a BoolFlag, which is false by default. So right now, we disable memory output by default. The change you propose would make disable false by default, meaning it would be by default enabled. Which is not what we want, because in most cases memory output is too large to work with.

@simonshampoo
Copy link

so how do we enable memory output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants